lkml.org 
[lkml]   [2008]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] hiddev: Switch to unlocked_ioctl
Date
Am Montag 26 Mai 2008 10:55:09 schrieb Jiri Kosina:
> On Thu, 22 May 2008, Alan Cox wrote:
>
> > Push down the BKL. In some cases compat_ioctl already doesn't take the
> > BKL so we don't either.
>
> Thanks.
>
> > @@ -555,7 +559,10 @@ static int hiddev_ioctl(struct inode *inode, struct file *file, unsigned int cmd
> >       struct usbhid_device *usbhid = hid->driver_data;
> >       void __user *user_arg = (void __user *)arg;
> >       int i;
> > +     
> > +     /* Called without BKL by compat methods so no BKL taken */
> >  
> > +     /* FIXME: Who or what stop this racing with a disconnect ?? */
> >       if (!hiddev->exist)
> >               return -EIO;
>
> Oliver (added to CC) -- I vaguely remember you already fixing this race,
> but I don't seem to be able to find the patch anywhere. Do I just remember
> incorrectly?

I fixed a race between disconnect and open. Ioctl was not involved.

Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-05-26 12:11    [W:0.048 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site