Messages in this thread | | | Date | Mon, 26 May 2008 13:40:44 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/3] slub: record page flag overlays explicitly |
| |
Hi
This patch works well on my box. but I have one question.
> if (s->flags & DEBUG_DEFAULT_FLAGS) { > - if (!SlabDebug(page)) > - printk(KERN_ERR "SLUB %s: SlabDebug not set " > + if (!PageSlubDebug(page)) > + printk(KERN_ERR "SLUB %s: SlubDebug not set " > "on slab 0x%p\n", s->name, page); > } else { > - if (SlabDebug(page)) > - printk(KERN_ERR "SLUB %s: SlabDebug set on " > + if (PageSlubDebug(page)) > + printk(KERN_ERR "SLUB %s: SlubDebug set on " > "slab 0x%p\n", s->name, page); > } > }
Why if(SLABDEBUG) check is unnecessary?
| |