Messages in this thread | | | Date | Mon, 26 May 2008 16:23:17 -0400 | From | Alan Cox <> | Subject | Re: [PATCH] video4linux: Push down the BKL |
| |
On Mon, May 26, 2008 at 01:59:51PM -0300, Mauro Carvalho Chehab wrote: > cx18 and ivtv (see the attached log). Also, IMO, it would be better if you > split drivers/net/tun.c into a different changeset.
That was most definitely not intended to be in the video patches 8)
> The next step can be to add the obvious locks inside video_ioctl2_unlocked(). Like, for > example, locking the VIDIOC_S calls, if someone is calling the corresponding > VIDIOC_G or VIDIOC_TRY ones.
Concentrate on the dats structures not the code - its one of those oft quoted and very true rules - "lock data not code"
I'll tidy these up later in the week as I get time and merge them against a current linux-next tree in bits with the rework done.
Alan
| |