lkml.org 
[lkml]   [2008]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/3] Implement generic freeze feature
> +	if (test_and_set_bit(BD_FREEZE_OP, &bdev->bd_state))
> + return ERR_PTR(-EBUSY);
> +
> + sb = get_super_without_lock(bdev);
> +
> + /* If super_block has been already frozen, return. */
> + if (sb && sb->s_frozen != SB_UNFROZEN) {
> + put_super(sb);
> + clear_bit(BD_FREEZE_OP, &bdev->bd_state);
> + return sb;
> + }

The BD_FREEZE_OP flag in the block_device already prevents multiple
freezes for a singe block device, so there is no need for this
additional check and the get_super_without_lock helper.

> down(&bdev->bd_mount_sem);

And with that flag bd_mount_sem is also obsolete for preventing the
multiple freeze operations. We still need investigate what
synchronization we need vs unmount which also takes bd_mount_sem without
every having document what it exactly protects.



\
 
 \ /
  Last update: 2008-05-25 21:35    [W:0.053 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site