lkml.org 
[lkml]   [2008]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] SERIAL: Simplify code using ARRAY_SIZE() macro.
From
Date
On Sun, 2008-05-25 at 13:09 -0400, Robert P. J. Day wrote:
> > > diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c
> > > index bbf5bc5..71c56c1 100644
> > > --- a/drivers/serial/68328serial.c
> > > +++ b/drivers/serial/68328serial.c
> > > @@ -1413,10 +1413,10 @@ static void m68328_set_baud(void)
> > > USTCNT = ustcnt & ~USTCNT_TXEN;
> > >
> > > again:
> > > - for (i = 0; i < sizeof(baud_table) / sizeof(baud_table[0]); i++)
> > > + for (i = 0; i < BAUD_TABLE_SIZE); i++)
> > typo? does this compile?
> will resubmit.

There are only two uses of BAUD_TABLE_SIZE
and MCFRS_BAUD_TABLE_SIZE.

I think it better to avoid
#define SOME_SIZE ARRAY_SIZE(some_array)
and use ARRAY_SIZE(some_array) where possible.

NR_PORTS seems to be an exception.




\
 
 \ /
  Last update: 2008-05-25 20:49    [W:0.040 / U:3.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site