lkml.org 
[lkml]   [2008]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver
Hi Anton,

On Fri, 23 May 2008 22:28:42 +0400 Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
>
> +++ b/drivers/mmc/host/of_mmc_spi.c

> +static int of_mmc_spi_probe(struct spi_device *spi)

> + /*
> + * mmc_spi_probe will use drvdata, so we can't use it. Use node's
> + * data instead.
> + */
> + spi->dev.archdata.of_node->data = oms;

If you delay this assignment, you may not have to clean it up in the
error path.

> + ocr_mask = of_get_property(np, "linux,mmc-ocr-mask", &size);

You should really explicitly include linux/of.h to use of_get_property etc

> +int __devexit of_mmc_spi_remove(struct spi_device *spi)
> +{
> + struct of_mmc_spi *oms = spi->dev.archdata.of_node->data;
> + int ret;
> +
> + ret = mmc_spi_remove(spi);
> + if (ret)
> + return ret;

Maybe you should do this last so that you don't leak more than necessary
if mmc_spi_remove fails. (I don't know what state mmc_spi_remove leaves
stuff in if it fails ...)

> +static struct spi_driver of_mmc_spi_driver = {
> + .driver = {
> + .name = "of_mmc_spi",
> + .bus = &spi_bus_type,

This is initialised by spi_register_driver().

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-05-24 04:39    [W:0.101 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site