Messages in this thread | | | Date | Fri, 23 May 2008 17:11:55 +0200 (CEST) | From | Roman Zippel <> | Subject | Re: [patch 06/14] hfsplus: remove hfsplus_permission() |
| |
Hi,
On Thu, 22 May 2008, Miklos Szeredi wrote:
> > As I said to allow lookup on files. > > That requires a quite bit more support from the VFS than just allowing > lookup to work on regular files without x bits. You'll have big > trouble with hard links for example: the VFS doesn't like non-leaf > dentries to be aliased. > > Besides hfsplus_permission() did not differentiate between execve on > the file and lookup on that file, allowing both. Which is obviously > wrong.
I'm not saying it's perfect. I wished there was a MAY_LOOKUP to clearly differentiate both cases. For now I'd rather keep it as it is and I'll look into it when I find the time.
bye, Roman
| |