Messages in this thread | | | Date | Fri, 23 May 2008 13:58:15 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 1/1] UIO: Add a write() function to enable/disable interrupts |
| |
Hello Tom,
> > Tom Spink wrote: > >> The added benefit is that the code becomes less complex, as you don't > >> have to check buffer sizes and copy the integer from userspace. > > AFAIK this is wrong. You need to copy the integer from userspace in > > uio_ioctl. Actually it's a value coming from user space, so you need to > > do it somewhere. > > Not really in this case. It's not a *pointer* to a value in > userspace, so you don't need to copy anything. If it was being used > to point to a memory location holding a value, then yes, it would need > to be copied across. But in this case, it's just being used to pass > across 1 or 0. ah, OK, you're right. Thanks for correcting my correction :-)
Uwe
-- Uwe Kleine-König, Software Engineer Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |