lkml.org 
[lkml]   [2008]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] snapshot: Push BKL down into ioctl handlers
> > 
> > + lock_kernel();
> > +
>
> Hm, well, I admit I'm a bit ignorant as far as the chardev locking is
> concerned, but can you please tell me why would that be wrong if we didn't call
> lock_kernel() here at all?

I've just been pushing the lock down. If the code already has enough
internal locking for things like multiple ioctls in parallel then you can
probably kill it entirely - but that needs someone who knows that driver
well to decide and evaluate.


\
 
 \ /
  Last update: 2008-05-23 13:21    [W:0.037 / U:1.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site