Messages in this thread | | | Date | Wed, 21 May 2008 13:19:32 -0500 | From | "Steve French (smfltc)" <> | Subject | Re: Re: [PATCH] usb-storage: don't call utsname() |
| |
Greg KH wrote: > On Wed, May 21, 2008 at 01:51:17PM -0400, Alan Stern wrote: > >> This patch (as1100) replaces the core-kernel function call to utsname() >> in usb-storage with the UTS_RELEASE macro. It's used only for warning >> about extra unusual_devs entries. >> >> Signed-off-by: Alan Stern <stern@rowland.harvard.edu> >> > > Why? With this change, if you change the version number, the file will > have to be rebuilt. Without the change, the file will not need to be > rebuilt, right? > > I thought that was why this change was made a while ago, to prevent > things from having to be rebuilt that didn't need to be > I agree - what was wrong with utsname->release ... it seems odd to statically build the kernel's version number into a module - it should be something we should be able to query (and it shouldn't change without reboot so accessing it is not racy). Access to other fields in the structure (nodename, domainname etc.) might need to be included in a macro but I didn't see one in utsname.h for this.
| |