Messages in this thread | | | Date | Tue, 20 May 2008 15:45:51 -0700 (PDT) | Subject | Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc from lib/hexdump.c instead | From | David Miller <> |
| |
From: Harvey Harrison <harvey.harrison@gmail.com> Date: Tue, 20 May 2008 15:40:12 -0700
> On Tue, 2008-05-20 at 15:36 -0700, David Miller wrote: > > From: Denis Cheng <crquan@gmail.com> > > Date: Mon, 19 May 2008 02:37:44 +0800 > > > > > Here the local hexbuf is a duplicate of global const char hex_asc from > > > lib/hexdump.c, except the hex letters' cases: > > > > > > const char hexbuf[] = "0123456789ABCDEF"; > > > > > > const char hex_asc[] = "0123456789abcdef"; > > > > > > and here to print HW addresses, the hex cases are not significant. > > > > > > Signed-off-by: Denis Cheng <crquan@gmail.com> > > > > Applied, thanks. > > You may want to use the hex_asc_hi, hex_asc_lo helpers to do the > mask/shifts for you.
Good idea, I'll revert, Denis can you generate a new patch?
Thanks.
| |