lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc
Date
On Monday 12 May 2008 23:38, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
>
> ---
>
> drivers/net/ehea/ehea_main.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
> index f9bc21c..fd4be0d 100644
> --- a/drivers/net/ehea/ehea_main.c
> +++ b/drivers/net/ehea/ehea_main.c
> @@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev,
> port->vgrp = grp;
>
> cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL);
> if (!cb1) {
> ehea_error("no mem for cb1");
> goto out;
> }
>
> - memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter));
> -
> hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id,
> H_PORT_CB1, H_PORT_CB1_ALL, cb1);
> if (hret != H_SUCCESS)
> ehea_error("modify_ehea_port failed");
>
> kfree(cb1);
> out:
> return;
>
The patch looks good.

Acked-by: Jan-Bernd Themann <themann@de.ibm.com>

Thanks,
Jan-Bernd


\
 
 \ /
  Last update: 2008-05-20 15:59    [W:0.075 / U:2.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site