Messages in this thread | | | From | Jan-Bernd Themann <> | Subject | Re: [PATCH] drivers/net/ehea - remove unnecessary memset after kzalloc | Date | Tue, 20 May 2008 14:53:57 +0100 |
| |
On Monday 12 May 2008 23:38, Joe Perches wrote: > Signed-off-by: Joe Perches <joe@perches.com> > > --- > > drivers/net/ehea/ehea_main.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c > index f9bc21c..fd4be0d 100644 > --- a/drivers/net/ehea/ehea_main.c > +++ b/drivers/net/ehea/ehea_main.c > @@ -2207,18 +2207,16 @@ static void ehea_vlan_rx_register(struct net_device *dev, > port->vgrp = grp; > > cb1 = kzalloc(PAGE_SIZE, GFP_KERNEL); > if (!cb1) { > ehea_error("no mem for cb1"); > goto out; > } > > - memset(cb1->vlan_filter, 0, sizeof(cb1->vlan_filter)); > - > hret = ehea_h_modify_ehea_port(adapter->handle, port->logical_port_id, > H_PORT_CB1, H_PORT_CB1_ALL, cb1); > if (hret != H_SUCCESS) > ehea_error("modify_ehea_port failed"); > > kfree(cb1); > out: > return; > The patch looks good.
Acked-by: Jan-Bernd Themann <themann@de.ibm.com>
Thanks, Jan-Bernd
| |