Messages in this thread | | | Date | Tue, 20 May 2008 14:22:17 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH] Fixups to ATA ACPI hotplug |
| |
On Tue, May 20, 2008 at 03:18:32PM +0200, Holger Macht wrote:
> + if (kobj && !is_dock_event) { > + sprintf(event_string, "BAY_EVENT=%d", event); > + kobject_uevent_env(kobj, KOBJ_CHANGE, envp);
I think we want to do the _EJ0 checking before this, otherwise we'll generate two uevents for the same removal on some hardware. Otherwise, looks good.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |