lkml.org 
[lkml]   [2008]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Extend list debugging to cover hlists
On Fri, May 02, 2008 at 12:49:22PM -0600, Matthew Wilcox wrote:
> On Thu, May 01, 2008 at 01:32:09PM -0700, Arjan van de Ven wrote:
> > I like the concept of the patch; however...
> > BUG() is a tad on the rude side... how about WARN_ON(1) ?
>
> I'm just copying the conventions of the code above. If those should be
> WARN_ON(1) then that should be a followup patch.

No objections from me either way. I chose to BUG originally because
the bug I was chasing was corrupting memory in such a way that we'd
die horribly shortly afterwards anyway.

Dave

--
http://www.codemonkey.org.uk


\
 
 \ /
  Last update: 2008-05-02 21:09    [W:0.799 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site