Messages in this thread | | | Date | Fri, 2 May 2008 17:34:06 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH] clocksource: Fix permissions for available_clocksource |
| |
On Fri, 2 May 2008, Heiko Carstens wrote: > On Fri, May 02, 2008 at 04:36:37PM +0200, Thomas Gleixner wrote: > > On Fri, 2 May 2008, Heiko Carstens wrote: > > > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > > > > > File permissions for > > > /sys/devices/system/clocksource/clocksource0/available_clocksource > > > are 600 which allows write access. But this is in fact a read only > > > file. So change permissions to 400. > > > > Indeed. The question is whether we should make this 444. There is no > > harm, when users can read the info. Same applies for the > > current_clocksource entry, making it 644 should be fine. > > Sure, I can send an on-top patch for this.
Yes, please.
> Btw. did you recently try writing "jiffies" to current_clocksource? > That seems to be a trick to stop the clock...
Hmm, that's after the kernel switched to highres and/or nohz, right ? This came up earlier, but it got dropped from my to todo list. :( Will have a look.
Thanks,
tglx
| |