Messages in this thread | | | Date | Mon, 19 May 2008 22:34:55 -0400 | From | Theodore Tso <> | Subject | Re: [PATCH 4/4] ext4: call blkdev_issue_flush on fsync |
| |
On Fri, May 16, 2008 at 02:09:56PM -0500, Eric Sandeen wrote: > To ensure that bits are truly on-disk after an fsync, > we should call blkdev_issue_flush if barriers are supported.
This patch isn't necessary, and in fact will cause a double flush. When you call fsync(), it calls ext4_force_commit(), and we do a the equivalent of a blkdev_issue_flush() today (which is what happenes when you do a submit_bh(WRITE_BARRIER, bh), which is what setting set_ordered_mode(bh) ends up causing.
- Ted
| |