Messages in this thread | | | Date | Sat, 17 May 2008 22:45:08 +0200 | From | Willy Tarreau <> | Subject | Re: mplayer v4l hangs in 2.6.25.2/4 (likely regression) |
| |
On Sat, May 17, 2008 at 01:20:50PM -0700, Arjan van de Ven wrote: > On Sat, 17 May 2008 22:06:12 +0200 > "koos vriezen" <koos.vriezen@gmail.com> wrote: > > > 2008/5/17 Arjan van de Ven <arjan@infradead.org>: > > > > > > so.. bttv first takes "fh->cap.vb_lock" in vidiocgmbuf, then > > > > calls videobuf_mmap_setup(), and the first thing that does > > is to also take fh->cap.vb_lock! This isn't even an ABBA deadlock, > > but a straight AA deadlock :) > > > > Looks like I'm the only one actually running this code ;-) > > > > > and here is an (untest) patch that should fix this problem: > > > Koos, can you apply this to your kernel tree and report back if this > > > fixes your deadlock? > > > > patching file drivers/media/video/bt8xx/bttv-driver.c > > patching file drivers/media/video/videobuf-core.c > > Hunk #1 succeeded at 335 (offset 4 lines). > > Hunk #2 succeeded at 1093 (offset -36 lines). > > patching file include/media/videobuf-core.h > > Hunk #1 succeeded at 227 (offset -10 lines). > > > > Deadlock is gone, only mplayer fails to unmute the audio. > > that's something else entirely ;) > > I'll call your deadlock bug fixed by the patch... > > Mauro: will you send this on to Linus or should this go direct?
also please do not forget to CC stable.
Willy
| |