lkml.org 
[lkml]   [2008]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 09/15] add some sanity checks to get_scan_ratio
On Thu, May 15, 2008 at 10:12 PM, Rik van Riel <riel@redhat.com> wrote:
> On Thu, 15 May 2008 15:34:51 +0900
> "MinChan Kim" <minchan.kim@gmail.com> wrote:
>
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -1375,8 +1375,7 @@ static unsigned long shrink_zone(int priority, struct zon
>> * rebalance the anon lru active/inactive ratio.
>> */
>> if (scan_global_lru(sc) && inactive_anon_low(zone))
>> - shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc,
>> - priority);
>> + shrink_inactive_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
>>
>> throttle_vm_writeout(sc->gfp_mask);
>> return nr_reclaimed;
>
> shrink_active_list, but yes, that is the idea.

But you used argument with NR_ACTIVE_ANON during call shrink_list.
I think It is not your intention.
So, you have to change LRU_ACTIVE_ANON or call shrink_active_list directly.




--
Kinds regards,
MinChan Kim


\
 
 \ /
  Last update: 2008-05-16 08:45    [W:0.048 / U:2.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site