Messages in this thread | | | Date | Thu, 15 May 2008 16:09:47 +0800 | From | "Bryan Wu" <> | Subject | Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers to fix more potential unaligned issues. |
| |
On Thu, May 15, 2008 at 4:03 PM, Jie Zhang <jie.zhang@analog.com> wrote: > Oliver Neukum wrote: >> >> Am Donnerstag 15 Mai 2008 08:19:24 schrieb Bryan Wu: >>> >>> --- a/drivers/usb/host/uhci-hub.c >>> +++ b/drivers/usb/host/uhci-hub.c >>> @@ -253,7 +253,7 @@ static int uhci_hub_control(struct usb_hcd *hcd, u16 >>> typeReq, u16 wValue, >>> switch (typeReq) { >>> case GetHubStatus: >>> - *(__le32 *)buf = cpu_to_le32(0); >>> + put_unaligned_le32(0, buf); >> >> What is supposed to make all these changes a good idea? >> > Since buf might not be 4-byte aligned. >
And this change follows Harvey Harrison's patch's style:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a5abdeafedf722b0f3f357f4a23089a686b1b80d
-Bryan
| |