lkml.org 
[lkml]   [2008]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 13/24] vfs: utimes cleanup
From
Date
> > + * do_futimesat - change times on filename
>
> > +int do_utimes(int dfd, char __user *filename, struct timespec *times, int flags)
>
> Erm... Is there any reason to
> * have do_utimes() used anywhere
> * _not_ have do_futimesat() called "do_utimes"?

Review ping-pong. My original patch did that, and Christoph didn't
like it. I don't care that much actually, one thing I like better in
the second version is to have a separate function for the path lookup
thing (now called do_utimes(), but it could be renamed to
name_utimes() or whatever).

Miklos


\
 
 \ /
  Last update: 2008-05-15 09:49    [W:0.027 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site