Messages in this thread | | | Subject | Re: [patch 13/24] vfs: utimes cleanup | From | Miklos Szeredi <> | Date | Thu, 15 May 2008 09:45:17 +0200 |
| |
> > + * do_futimesat - change times on filename > > > +int do_utimes(int dfd, char __user *filename, struct timespec *times, int flags) > > Erm... Is there any reason to > * have do_utimes() used anywhere > * _not_ have do_futimesat() called "do_utimes"?
Review ping-pong. My original patch did that, and Christoph didn't like it. I don't care that much actually, one thing I like better in the second version is to have a separate function for the path lookup thing (now called do_utimes(), but it could be renamed to name_utimes() or whatever).
Miklos
| |