lkml.org 
[lkml]   [2008]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] init - fix building bug and potential buffer overflow
On 15-05-08 23:15, Linus Torvalds wrote:

> Talking about cleanups, why the *hell* does print_fn_descriptor_symbol()
> take an "unsigned long", when every single user would want to give it a
> pointer?
>
> Would somebody please want to move that cast into the macro (or better
> yet, make it an inline function that takes a 'void *'), and remove all the
> casts from the callers?

[ ... ]

> + print_fn_descriptor_symbol("calling %s()\n",
> + (unsigned long) call);


And while that person is at it, could he or she please remove the silly
() from the "foo+0x0/0x1234()" (or the "foo+0x0/0x1234 [bar]()" or the
"0x12345678()").

Rene.


\
 
 \ /
  Last update: 2008-05-16 00:45    [W:0.053 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site