Messages in this thread | | | Date | Fri, 16 May 2008 00:44:27 +0200 | From | Rene Herman <> | Subject | Re: [PATCH] init - fix building bug and potential buffer overflow |
| |
On 15-05-08 23:15, Linus Torvalds wrote:
> Talking about cleanups, why the *hell* does print_fn_descriptor_symbol() > take an "unsigned long", when every single user would want to give it a > pointer? > > Would somebody please want to move that cast into the macro (or better > yet, make it an inline function that takes a 'void *'), and remove all the > casts from the callers?
[ ... ]
> + print_fn_descriptor_symbol("calling %s()\n", > + (unsigned long) call);
And while that person is at it, could he or she please remove the silly () from the "foo+0x0/0x1234()" (or the "foo+0x0/0x1234 [bar]()" or the "0x12345678()").
Rene.
| |