lkml.org 
[lkml]   [2008]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ???
On Thu, 15 May 2008 23:26:22 +0200
"Christophe Jaillet" <christophe.jaillet@wanadoo.fr> wrote:

> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against linux/drivers/net/r6040.c.
>
> Compared to other places in the kernel, I think that this driver
> misuses the function round_jiffies.
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> ---
>
> --- linux 2.6.25/drivers/net/r6040.c 2008-05-15
> 23:21:28.000000000 +0200 +++ linux
> 2.6.25/drivers/net/r6040.c.cj 2008-05-15 22:16:44.000000000
> +0200 @@ -733,7 +733,7 @@ static void r6040_timer(unsigned long da }
>
> /* Timer active again */
> - mod_timer(&lp->timer, jiffies + round_jiffies(HZ));
> + mod_timer(&lp->timer, round_jiffies(jiffies + HZ));
> }
>

good catch!
Acked-by: Arjan van de Ven <arjan@linux.intel.com>


\
 
 \ /
  Last update: 2008-05-15 23:45    [W:0.032 / U:2.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site