lkml.org 
[lkml]   [2008]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer
On Fri, May 16, 2008 at 12:12:15AM +0900, Atsushi Nemoto wrote:
> The zd1211rw driver uses unaligned stack buffer for USB control
> message. But it might cause stack corruption on non-coherent
> platform, such as MIPS. Use DMA-aware buffers for USB transfer.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Nemoto,

This looks like a reasonable fix to me. I would prefer to see a
comment in the code indicating why you are reusing the "p" buffer
instead of simply using "ret" directly. Also, I think the style
suggestion by Michael Buesch would make the code appear more idiomatic
as well.

Thanks!

John
--
John W. Linville
linville@tuxdriver.com


\
 
 \ /
  Last update: 2008-05-15 21:55    [W:0.044 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site