lkml.org 
[lkml]   [2008]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][PCI]: Introduce pci_find_capability_cached and make MSI use it
Em Thu, May 15, 2008 at 11:04:07AM -0600, Matthew Wilcox escreveu:
> On Thu, May 15, 2008 at 01:04:26PM -0300, Arnaldo Carvalho de Melo wrote:
> > So I implemented pci_find_capability_cached and made MSI use it
> > for good measure, please consider applying.
>
> As I told you on IRC, this is just the MSI code being complete crap.
> It should be caching the offset itself. We shouldn't have this extra
> array in the struct pci_dev just because MSI is broken.

Well, we can certainly do that, its just that I did this first and
thought that perhaps there could be some other users, but I see that 44
extra bytes per pci_dev can be a pain if the only one to reap benefits
is MSI, can't you think of any other users? I couldn't detect any so far
in my admitedly limited testing.

- Arnaldo


\
 
 \ /
  Last update: 2008-05-15 19:13    [W:0.057 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site