Messages in this thread | | | Date | Thu, 15 May 2008 14:10:03 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH][PCI]: Introduce pci_find_capability_cached and make MSI use it |
| |
Em Thu, May 15, 2008 at 11:04:07AM -0600, Matthew Wilcox escreveu: > On Thu, May 15, 2008 at 01:04:26PM -0300, Arnaldo Carvalho de Melo wrote: > > So I implemented pci_find_capability_cached and made MSI use it > > for good measure, please consider applying. > > As I told you on IRC, this is just the MSI code being complete crap. > It should be caching the offset itself. We shouldn't have this extra > array in the struct pci_dev just because MSI is broken.
Well, we can certainly do that, its just that I did this first and thought that perhaps there could be some other users, but I see that 44 extra bytes per pci_dev can be a pain if the only one to reap benefits is MSI, can't you think of any other users? I couldn't detect any so far in my admitedly limited testing.
- Arnaldo
| |