Messages in this thread | | | Date | Wed, 14 May 2008 23:20:14 -0700 (PDT) | Subject | Re: [PATCH] list_for_each_rcu must die: networking | From | David Miller <> |
| |
From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Date: Thu, 15 May 2008 10:56:07 +0530
> Paul E. McKenney wrote: > > All uses of list_for_each_rcu() can be profitably replaced by the > > easier-to-use list_for_each_entry_rcu(). This patch makes this change > > for networking, in preparation for removing the list_for_each_rcu() > > API entirely. > > > > Updated to remove the two now-unused variables as noted by Dave Miller, > > and also to fix my bonehead error detected by Kamalesh Babulal and > > Alexey Dobriyan. It now passes LTP on POWER. And also has valid SOB. > > Some days it just doesn't pay to get out of bed... > > Hi Paul, > > Thanks, the patch fixes the oops. > > Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> > > Acked-by: David S. Miller <davem@davemloft.net> (lkml.org/lkml/2008/4/23/448) > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
I'm fine with these changes, and I acked them already. They belong as a set with the other list_for_each_rcu killing patches, so I'm fine with them going all together in Andrew's tree.
Thanks!
| |