Messages in this thread | | | Date | Thu, 15 May 2008 19:02:46 +0300 | From | Adrian Bunk <> | Subject | Re: [GIT PATCHES] V4L/DVB fixes for 2.6.26 |
| |
On Wed, May 14, 2008 at 05:04:05PM -0300, Mauro Carvalho Chehab wrote: >... > > but otherwise that > > would be a straightforward solution to solve these problems. > > This will solve several troubles. Still, I think that there are still some > other missing dependencies (like INPUT, on drivers that select IR).
We could select INPUT from drivers/media/
And FW_LOADER should really select HOTPLUG - there's no good reason for FW_LOADER to be a user-visible option with dependencies.
But these two are problems that are only relevant for randconfig users while the I2C troubles hit real users, so I want to attack the I2C issues first.
> > Any problem I miss or should I bake a patch? > > I can't see any trouble on this approach. Feel free to work on it.
First issue when working on it:
The dependencies between VIDEO_IR and VIDEO_IR_I2C look wrong (consider VIDEO_IR=y and I2C=m).
It's not a problem since currently all users of VIDEO_IR also depend on I2C.
Should I fix the dependency or can I let VIDEO_IR select I2C and remove VIDEO_IR_I2C?
> Thanks, > Mauro
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |