Messages in this thread | | | Date | Thu, 15 May 2008 13:58:08 +0100 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH] x86/xen: fix arbitrary_virt_to_machine() |
| |
Jan Beulich wrote: > While I realize that the function isn't currently being used, I still > think an obvious mistake like this should be corrected. > > Signed-off-by: Jan Beulich <jbeulich@novell.com> > > --- a/arch/x86/xen/mmu.c > +++ b/arch/x86/xen/mmu.c > @@ -60,7 +60,7 @@ xmaddr_t arbitrary_virt_to_machine(unsig > { > unsigned int level; > pte_t *pte = lookup_address(address, &level); > - unsigned offset = address & PAGE_MASK; > + unsigned offset = address & (PAGE_SIZE - 1); >
Yeah. But I'd prefer "~PAGE_MASK".
J
| |