Messages in this thread | | | Date | Thu, 15 May 2008 13:06:35 +0900 | From | Paul Mundt <> | Subject | Re: Taint kernel after WARN_ON(condition) v2 |
| |
On Wed, Feb 13, 2008 at 03:55:20PM +0100, Haavard Skinnemoen wrote: > On Wed, 13 Feb 2008 22:27:40 +0800 > Nur Hussein <nurhussein@gmail.com> wrote: > > > This does not work on architectures where WARN_ON has its own definition. > > These archs are: > > 1. s390 > > 2. superh > > 3. avr32 > > 4. parisc > > Hmm. Relying on the generic code in lib/bug.c qualifies as "own > definition" these days? I think the patch below should take care of all > four...unless I've misunderstood something. > > Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com> > > diff --git a/lib/bug.c b/lib/bug.c > index 530f38f..0d67419 100644 > --- a/lib/bug.c > +++ b/lib/bug.c > @@ -35,6 +35,7 @@ > > Jeremy Fitzhardinge <jeremy@goop.org> 2006 > */ > +#include <linux/kernel.h> > #include <linux/list.h> > #include <linux/module.h> > #include <linux/bug.h> > @@ -149,6 +150,7 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs) > (void *)bugaddr); > > show_regs(regs); > + add_taint(TAINT_WARN); > return BUG_TRAP_TYPE_WARN; > } >
I was just about to submit the exact same patch, so it looks like this slipped through the cracks. Andrew, please apply.
Acked-by: Paul Mundt <lethal@linux-sh.org>
| |