lkml.org 
[lkml]   [2008]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI: boot parameter to avoid expansion ROM memory allocation
On Mon, May 12, 2008 at 02:43:44PM -0700, Yinghai Lu wrote:
> On Mon, May 12, 2008 at 1:57 PM, Gary Hade <garyhade@us.ibm.com> wrote:
<snip>
> > --- linux-2.6.26-rc2/arch/x86/pci/common.c.orig 2008-05-12 10:59:58.000000000 -0700
> > +++ linux-2.6.26-rc2/arch/x86/pci/common.c 2008-05-12 11:22:05.000000000 -0700
> > @@ -121,6 +121,21 @@ void __init dmi_check_skip_isa_align(voi
> > dmi_check_system(can_skip_pciprobe_dmi_table);
> > }
> >
> > +static void __devinit pcibios_fixup_device_resources(struct pci_dev *dev)
> > +{
> > + struct resource *rom_r = &dev->resource[PCI_ROM_RESOURCE];
> > +
> > + if (pci_probe & PCI_NOASSIGN_ROMS) {
> > + if (rom_r->parent)
> > + return;
> > + if (rom_r->start) {
> > + /* we deal with BIOS assigned ROM later */
> > + return;
> > + }
> > + rom_r->start = rom_r->end = rom_r->flags = 0;
> > + }
> > +}
> > +
> > /*
> > * Called after each bus is probed, but before its children
> > * are examined.
> > @@ -128,7 +143,11 @@ void __init dmi_check_skip_isa_align(voi
> >
> > void __devinit pcibios_fixup_bus(struct pci_bus *b)
> > {
> > + struct pci_dev *dev;
> > +
> > pci_read_bridge_bases(b);
> > + list_for_each_entry(dev, &b->devices, bus_list)
> > + pcibios_fixup_device_resources(dev);
> > }
>
> or put check
> + if (pci_probe & PCI_NOASSIGN_ROMS) {
>
> out of loop?

I could certainly do that but I had intended that the new
pcibios_fixup_device_resources function act as a container where
other kinds of fixups could be added later. Do you (or others)
think the additional cycles consumed by this approach are an
issue here?

Thanks,
Gary

--
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503 IBM T/L: 775-4503
garyhade@us.ibm.com
http://www.ibm.com/linux/ltc



\
 
 \ /
  Last update: 2008-05-13 00:33    [W:0.072 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site