Messages in this thread | | | From | Oliver Endriss <> | Subject | Re: [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix | Date | Mon, 12 May 2008 19:30:10 +0200 |
| |
Ingo Molnar wrote: > > x86.git testing found the following build failure in 2.6.26-rc2: > > drivers/media/dvb/ttpci/fdump "/usr/lib/hotplug/firmware/dvb-ttpci-01.fw" dvb_ttpci_fw drivers/media/dvb/ttpci/av7110_firm.h > firmware file '/usr/lib/hotplug/firmware/dvb-ttpci-01.fw' not found > make[4]: *** [drivers/media/dvb/ttpci/av7110_firm.h] Error 255 > make[3]: *** [drivers/media/dvb/ttpci] Error 2 > > in this config: > > http://redhat.com/~mingo/misc/config-Mon_May_12_11_29_29_CEST_2008.bad > > the reason for the build bug is that the driver's Kconfig ignores the > PREVENT_FIRMWARE_BUILD=y config setting and tries to build the firmware > which (like other firmware build methods) relies on a non-upstream > firmware blob. The fix is to make the firmware build depend on > !PREVENT_FIRMWARE_BUILD. > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > drivers/media/dvb/ttpci/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux/drivers/media/dvb/ttpci/Kconfig > =================================================================== > --- linux.orig/drivers/media/dvb/ttpci/Kconfig > +++ linux/drivers/media/dvb/ttpci/Kconfig > @@ -33,7 +33,7 @@ config DVB_AV7110 > > config DVB_AV7110_FIRMWARE > bool "Compile AV7110 firmware into the driver" > - depends on DVB_AV7110 && !STANDALONE > + depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD > default y if DVB_AV7110=y > help > The AV7110 firmware is normally loaded by the firmware hotplug manager. >
Nak. because DVB_AV7110_FIRMWARE=y does not build any firmware.
If you set DVB_AV7110_FIRMWARE=y, the firmware file under DVB_AV7110_FIRMWARE_FILE must exist...
CU Oliver
-- ---------------------------------------------------------------- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ ----------------------------------------------------------------
| |