Messages in this thread | | | Date | Sat, 10 May 2008 20:12:51 +0100 | From | Al Viro <> | Subject | Re: [Patch 1/9] fs/exec.c: export free_arg_pages |
| |
On Thu, May 08, 2008 at 09:52:26PM +0800, WANG Cong wrote: > free_arg_pages() is used to clean the pages allocated by copy_strings_kenrel(). > Since copy_strings_kernel() is exported, so should be free_arg_pages().
Not really. free_arg_pages() cleans them all at once; copy_strings_kernel() adds to pile. free_arg_pages() is called once for _all_ of them. And that happens in fs/exec.c, so it doesn't need to be exported.
| |