lkml.org 
[lkml]   [2008]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: add sysfs configuration interface for CP2101
On Fri, Feb 29, 2008 at 12:35:12PM -0800, Andrew Morton wrote:

> > +static int enable_config = false;
>
> Should be either
>
> static int enable_config;
>
> or, if you're being very formal,
>
> static bool enable_config = false;
>
> or, if you're being less formal and want to avoid bloating the kernel image,
>
> static bool enable_config;

I've added detection of false as a 0 value in external and static
contexts; this should be reported in the 0.18:

ERROR: do not initialise statics to 0 or NULL
#1: FILE: Z118.c:1:
+static bool enable_config = false;

-apw


\
 
 \ /
  Last update: 2008-04-09 14:19    [W:0.088 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site