lkml.org 
[lkml]   [2008]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pop previous section in alternative.c
Steven Rostedt wrote:
> On Wed, 9 Apr 2008, Steven Rostedt wrote:
>
>> gcc expects all toplevel assembly to return to the original section type.
>> The code in alteranative.c does not do this. This caused some strange bugs
>> in sched-devel where code would end up in the .rodata section and when
>> the kernel sets the NX bit on all .rodata, the kernel would crash when
>> executing this code.
>>
>> This patch adds a .previous marker to return the code back to the
>> original section.
>>
>
> Oh, and this would not be complete without giving Andrew Pinski complete
> credit for telling me it wasn't a gcc bug but a bug in the toplevel asm
> code in the kernel. ;-)
>

In many ways it's kind of silly for this even to be in assembly, since
all it is is a sequence of comma-separated byte values; I guess it was
the easiest way to deal with it given the ".byte" prefix, but still...

-hpa


\
 
 \ /
  Last update: 2008-04-10 02:29    [W:0.552 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site