[lkml]   [2008]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [regression] e1000e broke e1000
Ingo Molnar wrote:
> The most common distro setup is E1000=m and E1000E=m. The most common
> embedded setup is _one_ of the two drivers as =y.

Agreed, and agreed.

> So i'm not sure why
> you are arguing about all this. Please just fix this bug, simple as
> that.

I haven't said NAK, but I think the suggested fix is a waste of time because

1) it breaks (by disallowing) a valid setup based on one report

2) it only happens to experienced kernel hackers with weird configs

3) the suggested fix binds together more tightly two drivers we are
trying to keep separate

4) it is a temporary situation that will go away in 2.6.26 anyway

So from my point of view, your request is to pick the breakage you don't
care about (#1, above) to fix the breakage you do care about.

It's a "pick your poison" choice, from my POV.

Given that POV, that's why I lean towards avoiding your Kconfig fix --
viewing this as a transition issue, and not something to be fixed by
limiting the choices of others.

But if everyone strongly agrees with you... go ahead and patch, I won't
NAK it.

I dislike the Kconfig system growing "temporary" hacks, which tend to
accumulate false dependencies over time. But I readily admit that's a
general principle and not a hard rule...


 \ /
  Last update: 2008-04-09 21:37    [W:0.090 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site