lkml.org 
[lkml]   [2008]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [12/18] Add support to allocate hugetlb pages that are larger than MAX_ORDER
> This looks like an off-by-one error here and in the code below -- it 
> should be ">= MAX_ORDER" not "> MAX_ORDER". Cf alloc_pages() in gfp.h:
>
> if (unlikely(order >= MAX_ORDER))
> return NULL;

True good point. Although it will only matter if some architecture
has MAX_ORDER sized huge pages :) x86-64 definitely hasn't.

I passed this code over to Nick so he'll hopefully incorporate the fix.

-Andi


\
 
 \ /
  Last update: 2008-04-09 19:55    [W:0.072 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site