Messages in this thread | | | Date | Wed, 9 Apr 2008 19:56:29 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] [12/18] Add support to allocate hugetlb pages that are larger than MAX_ORDER |
| |
> This looks like an off-by-one error here and in the code below -- it > should be ">= MAX_ORDER" not "> MAX_ORDER". Cf alloc_pages() in gfp.h: > > if (unlikely(order >= MAX_ORDER)) > return NULL;
True good point. Although it will only matter if some architecture has MAX_ORDER sized huge pages :) x86-64 definitely hasn't.
I passed this code over to Nick so he'll hopefully incorporate the fix.
-Andi
| |