Messages in this thread | | | Date | Wed, 9 Apr 2008 12:13:19 -0400 | Subject | Re: [NFS] Use a zero sized array for raw field in struct fid | From | "J. Bruce Fields" <> |
| |
On Tue, Apr 08, 2008 at 02:01:26PM +0100, Steven Whitehouse wrote: > >From b8732f8bea4e8abc331b8fa58a4047c91e2e7d02 Mon Sep 17 00:00:00 2001 > From: Steven Whitehouse <swhiteho@redhat.com> > Date: Tue, 8 Apr 2008 13:12:52 +0100 > Subject: [PATCH] [NFS] Use a zero sized array for raw field in struct fid > > The raw field's size can vary so we use a zero sized array since > gcc will not allow a variable sized array inside a union. This > has been tested with ext3 and gfs2 and relates to the bug > report: http://lkml.org/lkml/2007/10/24/374 and discussion > thread: http://lkml.org/lkml/2008/4/7/65
OK; queued for 2.6.26.--b.
> > Signed-off-by: Steven Whitehouse <swhiteho@redhat.com> > Cc: Christoph Hellwig <hch@infradead.org> > Cc: Neil Brown <neilb@suse.de> > Cc: J. Bruce Fields <bfields@fieldses.org> > Cc: Adrian Bunk <bunk@kernel.org> > > diff --git a/include/linux/exportfs.h b/include/linux/exportfs.h > index adcbb05..de8387b 100644 > --- a/include/linux/exportfs.h > +++ b/include/linux/exportfs.h > @@ -43,7 +43,7 @@ struct fid { > u32 parent_ino; > u32 parent_gen; > } i32; > - __u32 raw[6]; > + __u32 raw[0]; > }; > }; > > -- > 1.5.1.2 > > >
| |