Messages in this thread | | | Subject | Re: [GIT] Please pull NFS client fixes against linux-2.6.25-rc8 | From | Trond Myklebust <> | Date | Wed, 09 Apr 2008 09:37:31 -0400 |
| |
On Wed, 2008-04-09 at 09:27 -0400, Christoph Hellwig wrote: > On Wed, Apr 09, 2008 at 09:12:38AM -0400, Trond Myklebust wrote: > > That is what this does. For the case of no mmu, generic_file_mmap() > > compiles into a 'return -ENOSYS;' > > doh, I was under the impression we had a real implementation now. > Of course then it makes much more sense to just not set .mmap at all, > which gives the same effect in a more obvious way and without any > confusion to the reader. (actually that one gives -ENODEV which I > assume is for some reason more appropinquate)
I'm assuming there is a reason why the nommu folks want to return ENOSYS rather than ENODEV when mmap() is unsupported by the hardware.
Bryan, any comments to that?
-- Trond Myklebust Linux NFS client maintainer
NetApp Trond.Myklebust@netapp.com www.netapp.com
| |