Messages in this thread Patch in this message | | | From | "Denis V. Lunev" <> | Subject | [PATCH 6/29] reiserfs: use non-racy method for proc entries creation | Date | Tue, 8 Apr 2008 15:19:13 +0400 |
| |
Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data be setup before gluing PDE to main tree.
/proc entry owner is also added.
Signed-off-by: Denis V. Lunev <den@openvz.org> CC: reiserfs-dev@namesys.com CC: reiserfs-devel@vger.kernel.org --- fs/reiserfs/procfs.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/reiserfs/procfs.c b/fs/reiserfs/procfs.c index 8f86c52..b9dbeec 100644 --- a/fs/reiserfs/procfs.c +++ b/fs/reiserfs/procfs.c @@ -467,6 +467,7 @@ static const struct file_operations r_file_operations = { .read = seq_read, .llseek = seq_lseek, .release = seq_release, + .owner = THIS_MODULE, }; static struct proc_dir_entry *proc_info_root = NULL; @@ -475,12 +476,8 @@ static const char proc_info_root_name[] = "fs/reiserfs"; static void add_file(struct super_block *sb, char *name, int (*func) (struct seq_file *, struct super_block *)) { - struct proc_dir_entry *de; - de = create_proc_entry(name, 0, REISERFS_SB(sb)->procdir); - if (de) { - de->data = func; - de->proc_fops = &r_file_operations; - } + proc_create_data(name, 0, REISERFS_SB(sb)->procdir, + &r_file_operations, func); } int reiserfs_proc_info_init(struct super_block *sb) -- 1.5.3.rc5
| |