Messages in this thread | | | Date | Tue, 8 Apr 2008 18:01:46 +0800 | From | "eric miao" <> | Subject | Re: [PATCH 3/4] pxafb: move parallel LCD timing setup into dedicate function |
| |
On Tue, Apr 8, 2008 at 4:21 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Tue, 8 Apr 2008 12:05:16 +0800 "eric miao" <eric.y.miao@gmail.com> wrote: > > > @@ -636,61 +671,31 @@ static int pxafb_activate_var(struct > > fb_var_screeninfo *var, > > printk(KERN_ERR "%s: invalid lower_margin %d\n", > > fbi->fb.fix.id, var->lower_margin); > > #endif > > + /* Update shadow copy atomically */ > > + local_irq_save(flags); > > So this code will only ever work on uniprocessor machines? > > Is this a safe and reasonable assumption? >
Y, this is a reasonable assumption for PXA2xx/3xx, though as noted in the comment, it's too heavy for an local_irq_{save,restore} here, but a fix to this would involve more investigation, so I'd rather have this fixed later.
-- Cheers - eric
| |