Messages in this thread | | | Date | Tue, 8 Apr 2008 17:47:14 +0800 | From | "eric miao" <> | Subject | Re: [PATCH 4/4] pxafb: preliminary smart panel interface support |
| |
On Tue, Apr 8, 2008 at 5:16 PM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Tue, Apr 08, 2008 at 04:34:05PM +0800, eric miao wrote: > > > >From 3b14d02739b98ed8be3904914dd8b9d4a39fff25 Mon Sep 17 00:00:00 2001 > > From: Eric Miao <eric.miao@marvell.com> > > Date: Mon, 7 Apr 2008 15:57:56 +0800 > > Subject: [PATCH] pxafb: preliminary smart panel interface support > > > > Signed-off-by: Daniel Mack <daniel@caiaq.de> > > Acked-by: Eric Miao <eric.miao@marvell.com> > > --- > > Andrew: please see if this modified version applies: FB_PXA_SMARTPANEL > > defaults to "n" and removed the cast to void *, thanks - eric > > No need to add an explicit "default n" - defaulting to 'n' is the > default unless otherwise set. >
Yes, indeed. I'd like to address this issue in the next patch to abstract the output interface.
-- Cheers - eric
| |