Messages in this thread | | | Date | Tue, 8 Apr 2008 01:39:36 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH,RFC] Add call_rcu_sched() |
| |
On Tue, 8 Apr 2008 13:40:48 +0530 Gautham R Shenoy <ego@in.ibm.com> wrote:
> > > + rdp = RCU_DATA_CPU(cpu); > <-- here ------\ > > > + spin_lock_irqsave(&rdp->lock, flags); | > > > + | > > > + /* | > > > + * We are running on this CPU irq-disabled, so no | > > > + * CPU can go offline until we re-enable irqs. | > > | > > but, but, but. The cpu at `cpu' could have gone offline just before we | > > disabled local interrupts. | > | > In that case the CPU_DEAD callback should have migrated the rcu-lists to | > a cpu which is online. | | But local variable rdp might be pointing at the now-offlined CPU's data? -------/
| |