Messages in this thread |  | | Date | Tue, 8 Apr 2008 21:36:49 +0200 | From | "Bert Wesarg" <> | Subject | Re: [PATCH 1/3] x86: modify show_shared_cpu_map in intel_cacheinfo v3 |
| |
On Tue, Apr 8, 2008 at 8:43 PM, Mike Travis <travis@sgi.com> wrote: > --- linux-2.6.x86.sched.orig/arch/x86/kernel/cpu/intel_cacheinfo.c > +++ linux-2.6.x86.sched/arch/x86/kernel/cpu/intel_cacheinfo.c > @@ -591,20 +591,34 @@ static ssize_t show_size(struct _cpuid4_ > return sprintf (buf, "%luK\n", this_leaf->size / 1024); > } > > -static ssize_t show_shared_cpu_map(struct _cpuid4_info *this_leaf, char *buf) > +static ssize_t show_shared_cpu_map_func(struct _cpuid4_info *this_leaf, > + int type, char *buf) I don't know if this is more efficient or better or cleaner, but how about to pass the function pointer (ie. cpulist_scnprintf or cpumap_scnprintf)? You safe at least one condition.
> + n = type? > + cpulist_scnprintf(buf, len-2, *mask): > + cpumask_scnprintf(buf, len-2, *mask);
Thanks. Bert
|  |