Messages in this thread | | | Subject | Re: [PATCH] introduce HAVE_EFFICIENT_UNALIGNED_ACCESS Kconfig symbol | From | Johannes Berg <> | Date | Tue, 08 Apr 2008 18:00:49 +0200 |
| |
Stefan,
Thanks for the text review. I'll follow up with a new version in a minute.
> > --- everything.orig/arch/Kconfig 2008-04-04 23:42:50.000000000 +0200 > > +++ everything/arch/Kconfig 2008-04-04 23:52:15.000000000 +0200 > > @@ -36,3 +36,22 @@ config HAVE_KPROBES > > > > config HAVE_KRETPROBES > > def_bool n > > + > > +config HAVE_EFFICIENT_UNALIGNED_ACCESS > > + def_bool n > > + help > > + Some architectures are unable to perform unaligned accesses > > + without the use of get_unaligned/put_unaligned. Others are > > + unable to perform such accesses efficiently (e.g. trap on > > Wouldn't a comment be more appropriate instead of a help text? This > option shouldn't be a visible make XYZconfig prompt. > > I have no comment on the option itself; it's not my domain.
Note that the help text doesn't mean the option gets to be visible, only the one-line description does, as in
config XYZ bool "description"
vs. config XYZ bool
johannes [unhandled content-type:application/pgp-signature] | |