Messages in this thread |  | | Date | Tue, 08 Apr 2008 23:48:43 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 6/13] devres: implement managed iomap interface |
| |
Sergei Shtylyov wrote: > A very late comment but nevertheless... :-)
Better late than never.
> Those functions are going to break on 32-bit platforms with extended > physical address (well, that's starting with Pentiums which had 36-bit > PAE :-) AND devices mapped beyond 4 GB (e.g. PowerPC 44x). You should > have used resource_size_t for the 'offset' parameter. As this most > probably means that libata is broken on such platforms, I'm going to > submit a patch...
Yeah, right please go ahead. But I wonder whether any BIOS was actually crazy enough to map mmio region above 4G on 32bit machine.
-- tejun
|  |