Messages in this thread |  | | From | Jarod Wilson <> | Subject | Re: [PATCH] firewire: fw-ohci: conditionally log busReset interrupts | Date | Mon, 7 Apr 2008 17:28:14 -0400 |
| |
On Monday 07 April 2008 04:33:35 pm Stefan Richter wrote: > Add a debug option to watch bus reset interrupt events. Half of this > patch is taken from Jarod Wilson's first version of the JMicron fix. > > BusReset interrupts are only generated if the respective module > parameter flag was set before the controller is being initialized. We > keep this event masked otherwise to reduce IRQ load in normal operation > and to avoid potential problems with buggy chips. > > Note, this is unlike the other IRQ events whose logging can be enabled > any time after chip initialization. This and the influence on what > interrupts the chip generates is why I added an extra flag for it. > > Also, reorder the debug parameter flags according to their perceived > usefulness. > > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> > ---
Indeed, after discussing, this looks much safer.
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
-- Jarod Wilson jwilson@redhat.com
|  |