[lkml]   [2008]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch v2] doc: DMA-mapping.txt has undeclared variables [Bug 10397]
On Monday, April 07, 2008 9:01 am Matti Linnanvuori wrote:
> From: Matti Linnanvuori <>
> Fix undeclared variables in code examples.
> Consistently use pdev as the variable of type struct pci_dev *.
> Bug 10397.

I think Grant's comment still stands, "fix undeclared variables" isn't an
accurate description of what you're doing here...

That said, the patch itself looks fine to me, if a bit pedantic. The compiler
will catch any mismatched arguments in this case, and the rest of the
documentation is pretty clear that these routines take struct pci_dev not
struct device, so I'd be inclined to just leave it the way it is to avoid


 \ /
  Last update: 2008-04-07 18:09    [W:0.031 / U:5.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site