Messages in this thread |  | | Subject | Re: [patch 01/10] emm: mm_lock: Lock a process against reclaim | From | Peter Zijlstra <> | Date | Mon, 07 Apr 2008 15:55:48 +0200 |
| |
On Sat, 2008-04-05 at 02:41 +0200, Andrea Arcangeli wrote: > On Fri, Apr 04, 2008 at 04:12:42PM -0700, Jeremy Fitzhardinge wrote: > > I think you can break this if() down a bit: > > > > if (!(vma->vm_file && vma->vm_file->f_mapping)) > > continue; > > It makes no difference at runtime, coding style preferences are quite > subjective.
I'll have to concurr with Jeremy here, please break that monstrous if stmt down. It might not matter to the compiler, but it sure as hell helps for anyone trying to understand/maintain the thing.
|  |