[lkml]   [2008]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/1] [GPIO]: new arch-independent simple-gpio driver
On Wednesday 26 March 2008, Ben Nizette wrote:
> > +#define pr_devinit(fmt, args...) ({ static const __devinitdata char __fmt[] = fmt; printk(__fmt, ## args); })
> > +#define pr_init(fmt, args...) ({ static const __initdata char __fmt[] = fmt; printk(__fmt, ## args); })
> Should your pr_*init macros be accepted somewhere higher up the tree?
> Either that or dropped, it doesn't seem right wedging them in here.
> Sure it might cost you a few hundred bytes of RAM but would be nice to
> keep it all consistent across the kernel.

Me, I'm all in favor of getting rid of structural code bloat.
A few hundred bytes of such stuff shaved out a dozen drivers
on a given platforms would be almost free page saved! :)

So I'd be interested in seeing those get submitted ... but as
inline functions, not fancy macros. (Once they're submitted,
then let the flamage begin ... much less than kernel I18N!)

- Dave

 \ /
  Last update: 2008-04-06 01:01    [W:0.033 / U:2.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site