Messages in this thread |  | | Subject | Re: 2.6.25 intended change: smc:kbd_backlight vs. smc::kbd_backlight ? | From | Soeren Sonnenburg <> | Date | Sat, 05 Apr 2008 07:32:36 +0200 |
| |
On Fri, 2008-04-04 at 15:12 +0000, Justin Mattock wrote: > Hello; I noticed this as well, you loose the greatest feature; the > cool leds lights on the keyboard with the macbook pro, > A solution that worked for me was to compile pommed from the source > and edit kbd_backlight.h > regards; > Justin P. Mattock
Yeah, but it will not only affect pommed... and I don't see the rationale of introducing :: to separate things... so I think we should have another patch replacing the :: with ':' again to unbreak userspace for 2.6.25.
Could someone more official please respond to this regression (CCing Rafael to record it)
Soeren
> On Fri, Apr 4, 2008 at 6:54 AM, Soeren Sonnenburg <kernel@nn7.de> wrote: > > On Wed, 2008-04-02 at 20:58 +0200, Soeren Sonnenburg wrote: > > > Dear all, > > > > > > I am wondering whether the change from > > > > > > /sys/devices/platform/applesmc.768/leds/smc:kbd_backlight (2.6.24) > > > /sys/devices/platform/applesmc.768/leds/smc::kbd_backlight (2.6.25) > > > > > > is intentional? > > > > > > I recognized that it breaks current userspace applications changing the > > > keyboard background leds like pommed... > > > > OK it looks like commit 6c152beefbf90579d21afc4f7e075b1f801f9a75 from > > Richard Purdie, 'leds: Standardise LED naming scheme' introduced this > > change. > > > > Why do we need '::' instead of a single ':' (that would not have broken > > things)? > > > > Also sometimes only a single ':' seperator is used like in > > corgi:green:mail but e.g. not in clevo::mail ?! > > > > Soeren > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > >
|  |