Messages in this thread | | | Date | Thu, 1 May 2008 05:16:24 +0300 | From | Adrian Bunk <> | Subject | Re: olpc_battery_trigger_uevent() is unused |
| |
On Tue, Apr 29, 2008 at 07:01:37PM -0400, Andres Salomon wrote: > On Wed, 30 Apr 2008 01:29:51 +0300 > Adrian Bunk <bunk@kernel.org> wrote: > > > drivers/power/olpc_battery.c:olpc_battery_trigger_uevent() is unused. > > > > Should it have been used? > > > > cu > > Adrian > > > > It will get used once the olpc power management code makes it > upstream. The olpc_register_battery_callback stuff that Andrew removed > was related to that. > > Remove it now if you like, but I'm hoping to get it in for the 2.6.27 > merge window.
I'm not that trigger-happy. ;-)
I was actually more interested in whether it should have been used (AKA there would be a bug somewhere).
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |